linux-kernel - Re: restart_syscall: use freezable blocking call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 2 Apr 2015 13:34:04 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Sasha Levin <sasha.levin@...cle.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	maninder1.s@...sung.com, tglx@...utronix.de,
	Yogesh Narayan Gaur <yn.gaur@...sung.com>,
	AJEET YADAV <ajeet.y@...sung.com>
Subject: Re: restart_syscall: use freezable blocking call

On Thu, Apr 02, 2015 at 07:25:13PM +0200, Peter Zijlstra wrote:
> On Thu, Apr 02, 2015 at 12:03:08PM -0400, Sasha Levin wrote:
> > It's not correct.
> 
> Yay for lockdep ;-)
> 
> > [    0.645644] debug_check_no_locks_held (kernel/locking/lockdep.c:4178)
> 
> Should we also have that call in freezer_do_not_count() ?

I think conerting a general scheduling function like
schedule_hrtimeout to do freezable sleeps blindly is a pretty bad
idea.  This must be determined per specific sleep site.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/