linux-kernel - Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 3 Apr 2015 20:30:01 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	devel@...verdev.osuosl.org, mdcasey@...bloom.com,
	aysemelikeyurtoglu@...il.com, linux-kernel@...r.kernel.org,
	seanm@...nm.ca, Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] staging:rtl8192e: Change printk statements in
 rtllib_tx.c to use netdev_dev

On Fri, Apr 03, 2015 at 02:05:11PM -0400, Nicholas Krause wrote:
> 
> 
> On April 3, 2015 1:05:59 PM EDT, Greg KH <gregkh@...uxfoundation.org> wrote:
> >On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
> >> 
> >> 
> >> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter
> ><dan.carpenter@...cle.com> wrote:
> >> >
> >> >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb,
> >struct
> >> >net_device *dev)
> >> >>  	   IEEE_SOFTMAC_TX_QUEUE)) ||
> >> >>  	   ((!ieee->softmac_data_hard_start_xmit &&
> >> >>  	   (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
> >> >> -		printk(KERN_WARNING "%s: No xmit handler.\n",
> >> >> +		netdev_info(ieee->dev, "%s: No xmit handler.\n",
> >> >
> >> >
> >> >This should be netdev_warn().  There are a few other similar places.
> >> >
> >> >regards,
> >> >dan carpenter
> >> My bad will send in a v2 fixing this. 
> >
> >Please don't, I'm not going to be taking patches from you any _year_
> >soon.
> >
> >sorry,
> >
> >greg k-h
> Very well then I guess you seem to not trust me no matter how hard I
> try.  Therefore I will avoid helping out in any subsystems you are a
> maintainer of. 

You have not tried at all.  You submit patches that don't even apply
(like this one), are incorrect, or wrong in some other way.

You activly take up the time and energy of people who are contributing
to the kernel, that is why you were banned from vger.kernel.org.  You
also, when offered a way to learn and redeem yourself, ignored it, and
did something else.

What would you do with someone like youself if you were in our shoes?

back into my kill-file you go...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/