[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 03 Apr 2015 22:29:00 -0400
From: Peter Hurley <peter@...leysoftware.com>
To: Yinghai Lu <yinghai@...nel.org>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Jiri Slaby <jslaby@...e.cz>,
Andrew Morton <akpm@...ux-foundation.org>,
Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2] earlycon: 8250: Fix command line regression
On 04/03/2015 10:19 PM, Yinghai Lu wrote:
> On Fri, Apr 3, 2015 at 5:04 PM, Peter Hurley <peter@...leysoftware.com> wrote:
>> Restore undocumented behavior of kernel command line parameters of
>> the forms:
>> console=uart[8250],io|mmio|mmio32,<addr>[,options]
>> console=uart[8250],<addr>[,options]
>> where 'options' have not been specified; in this case, the hardware
>> is assumed to be initialized.
>
>
> Please separated bug fix and other documentation change to different patches.
No. The documentation reflects exactly what the bug fix is for.
> also fix the patch title to make it clear and you need to mention which commit
> cause the regression.
Please bisect and send bisect log so I know which commit broke
your setup.
> This patch fix regression for the hand over. Thanks.
>
> Another regression.
> when user have
> console=uart8250,io,0x3f8 console=uart8250,io,0x2f8
>
> before your patchset:
> port_0x3f8 is early console, and will be console later.
> and port_0x2f8 is ignored, because only ONE early console is allowed.
> and old console setup, only handle ttyS0.
>
> after your patchset:
> port_0x3f8 is early console, and will be console later.
> port_0x2f8 will become default console, as new console with match method
> treat all uart8250 as ttyS0.
>
> Please fix that too.
That's a new feature, not a regression.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists