linux-kernel - Re: [PATCH] Input: atkbd: Fix release quirk for Dell models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Apr 2015 10:06:10 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: atkbd: Fix release quirk for Dell models

On Monday 06 April 2015 01:53:43 Dmitry Torokhov wrote:
> On Mon, Apr 06, 2015 at 12:00:32AM +0200, Pali Rohár wrote:
> > On Sunday 05 April 2015 23:48:33 Dmitry Torokhov wrote:
> > > Hi Pali,
> > > 
> > > On Sun, Mar 29, 2015 at 04:36:19PM +0200, Pali Rohár wrote:
> > > > This patch fixes commit 61579ba83934 ("Input: atkbd -
> > > > expand Latitude's force release quirk to other Dells").
> > > > Before that commit release quirks were called for all
> > > > Dell Latitude models. After that commit only for
> > > > Portable Dell devices. But lot of Latitude models are
> > > > Laptop or Notebook DMI devices so quirks are not
> > > > called.
> > > > 
> > > > Release quirks are still needed also for new Dell
> > > > Latitude models, so this patch enables quirks for all
> > > > Portable, Laptop, Notebook and Sub-Notebook Dell
> > > > devices.
> > > 
> > > Does Dell use all these types for their laptops? What
> > > models do you know that need this quirk?
> > > 
> > > Thanks.
> > 
> > I do not if Dell use all types, but months ago Matthew wrote
> > to include also other numbers not only 9 (Laptop) and you
> > agreed.
> 
> Hmm, I tried looking back but I could not quite find the
> discussion.
> 

Search for Message-ID: <20141222175632.GB18556@...r-ws>
(this should be unique identifier for emails)

> > I do not know exact list of models which needs these quirks,
> > but before that commit (61579ba83934) it was used for all
> > Latitude models. At least I see that switches do not
> > generate release events and on older Latitude machines some
> > Fn keys do not generate them too.
> 
> So the question is still: what models do need this quirk and
> what chassis type they are used.
> 

My model:

$ cat /sys/class/dmi/id/chassis_type 
9
$ cat /sys/class/dmi/id/sys_vendor
Dell Inc.
$ cat /sys/class/dmi/id/product_name
Latitude E6440

> Regardless, I have not accepted quirks for force_release and
> atkbd keymaps for many years now as the task to adjust both
> keymap and force_release list has been offloaded to udev.
> 
> Thanks.

Ok, and what to do with kernel regressions? As before commit 
61579ba83934 it worked, because quirk was called for all Latitude 
(independently on chassis_type).

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)