linux-kernel - Re: [RESEND PATCH 4.0-rc5 v19 6/6] ARM: Add support for on-demand backtrace of other CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 08 Apr 2015 11:48:32 +0100
From:	Daniel Thompson <daniel.thompson@...aro.org>
To:	Hillf Danton <hillf.zj@...baba-inc.com>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [RESEND PATCH 4.0-rc5 v19 6/6] ARM: Add support for on-demand
 backtrace of other CPUs

On 08/04/15 09:35, Hillf Danton wrote:
>>
>> +void ipi_cpu_backtrace(struct pt_regs *regs)
>> +{
>> +	int cpu = smp_processor_id();
>> +
>> +	if (cpumask_test_cpu(cpu, to_cpumask(backtrace_mask))) {
>> +		printk_nmi_backtrace_this_cpu_begin();
>> +		pr_warn("FIQ backtrace for cpu %d\n", cpu);
>> +		if (regs != NULL)
>> +			show_regs(regs);
>> +		else
>> +			dump_stack();
>
> Help more if we could print both register and stack info.

I think this code already prints as much as it can in all cases.

The arch/arm implementation of show_regs() calls dump_stack() internally 
so the first case does show register and stack info.

In the second case, where regs is NULL because we have been called 
directly from task context, there aren't any saved regs for us to show.


Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/