linux-kernel - Re: [PATCHv4 1/1] thermal: intel Quark SoC X1000 DTS thermal driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 11 Apr 2015 12:04:11 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Ong Boon Leong <boon.leong.ong@...el.com>
Cc:	rui.zhang@...el.com, edubezval@...il.com,
	pure.logic@...us-software.ie, hock.leong.kweh@...el.com,
	andy.shevchenko@...il.com, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 1/1] thermal: intel Quark SoC X1000 DTS thermal driver

There might be a mismatch between the license stated in the comment at
the top of the (only) source file of this driver and the license ident
used in the MODULE_LICENSE() macro.

On Fri, 2015-04-10 at 12:07 +0800, Ong Boon Leong wrote:
> --- /dev/null
> +++ b/drivers/thermal/intel_quark_dts_thermal.c

> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.

This only states the license is GPL v2.

> +MODULE_LICENSE("Dual BSD/GPL");

And this states that there's a "GNU Public License v2 or BSD license
choice". But if that's what you want, shouldn't the BSD license be
copied in that comment too? (Please note that this is not a rhetorical
question.)

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/