linux-kernel - Re: [alsa-devel] [PATCH] ASoC: Intel: fix ifnullfree.cocci warnings

Open Source and information security mailing list archives

Date:	Mon, 13 Apr 2015 09:03:39 +0800
From:	"Jin, Yao" <yao.jin@...ux.intel.com>
To:	kbuild test robot <fengguang.wu@...el.com>
CC:	alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.de>,
	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, kbuild-all@...org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: fix ifnullfree.cocci warnings

The NULL check here is to proivde the protection for current code and
future potential code. It's possible that in future some code may
change the pointer ipc->msg and the author may miss the kfree here.

But anyway I'm ok if removing null check is the coding philosophy we
need to follow.

Thanks
JIn Yao

On 2015/4/13 3:06, kbuild test robot wrote:
> sound/soc/intel/common/sst-ipc.c:287:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> 
>  NULL check before some freeing functions is not needed.
> 
>  Based on checkpatch warning
>  "kfree(NULL) is safe this check is probably not required"
>  and kfreeaddr.cocci by Julia Lawall.
> 
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
> 
> CC: Jin Yao <yao.jin@...ux.intel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
>  sst-ipc.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/sound/soc/intel/common/sst-ipc.c
> +++ b/sound/soc/intel/common/sst-ipc.c
> @@ -283,8 +283,7 @@ void sst_ipc_fini(struct sst_generic_ipc
>  	if (ipc->tx_thread)
>  		kthread_stop(ipc->tx_thread);
>  
> -	if (ipc->msg)
> -		kfree(ipc->msg);
> +	kfree(ipc->msg);
>  }
>  EXPORT_SYMBOL_GPL(sst_ipc_fini);
>  
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives