linux-kernel - Re: [PATCH 7/7] modpost: handle relocations mismatch in __ex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 15 Apr 2015 10:35:39 +0200
From:	Quentin Casasnovas <quentin.casasnovas@...cle.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Quentin Casasnovas <quentin.casasnovas@...cle.com>,
	Thierry Reding <thierry.reding@...il.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table.

On Wed, Apr 15, 2015 at 12:57:37PM +0930, Rusty Russell wrote:
> 
> I've applied his patch, then the following:

Thanks.

> 
> modpost: handle -ffunction-sections
> 
> 52dc0595d540 introduced OTHER_TEXT_SECTIONS for identifying what
> sections could validly have __ex_table entries.  Unfortunately, it
> wasn't tested with -ffunction-sections, which some architectures
> use.
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Cc: Quentin Casasnovas <quentin.casasnovas@...cle.com>
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> 
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index cbd53e08769d..22dbc604cdb9 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -876,7 +876,7 @@ static void check_section(const char *modname, struct elf_info *elf,
>  #define TEXT_SECTIONS ".text", ".text.unlikely", ".sched.text", \
>  		".kprobes.text"
>  #define OTHER_TEXT_SECTIONS ".ref.text", ".head.text", ".spinlock.text", \
> -		".fixup", ".entry.text"
> +		".fixup", ".entry.text", ".exception.text", ".text.*"
>

Is there a reason we're not adding ".text.*" to TEXT_SECTIONS as opposed to
OTHER_TEXT_SECTIONS?  AFAIU, we'll not run the other modpost mismatch
checks when the kernel is compiled with -ffunction-sections otherwise.

I'll send a tentative fix for the divide-by-zero error shortly, sorry about
the mess.

Quentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/