linux-kernel - Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Apr 2015 11:10:08 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Matias Bjørling <m@...rling.me>
Cc:	hch@...radead.org, axboe@...com, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
	javier@...etta.io, keith.busch@...el.com
Subject: Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

A few things I spotted (while actually fiddling with 3/5).

On Wed, 2015-04-15 at 14:34 +0200, Matias Bjørling wrote:
> index f3dd028..58a8a71 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -221,6 +221,9 @@ static void blk_mq_rq_ctx_init(struct request_queue *q, struct blk_mq_ctx *ctx,
>  	rq->end_io = NULL;
>  	rq->end_io_data = NULL;
>  	rq->next_rq = NULL;
> +#if CONFIG_BLK_DEV_NVM

I think you meant
    #ifdef CONFIG_BLK_DEV_NVM

> +	rq->phys_sector = 0;
> +#endif
>  
>  	ctx->rq_dispatched[rw_is_sync(rw_flags)]++;
>  }

> --- /dev/null
> +++ b/block/blk-nvm.c

> +int nvm_register_target(struct nvm_target_type *tt)
> +{
> +	int ret = 0;
> +
> +	down_write(&_lock);
> +	if (nvm_find_target_type(tt->name))
> +		ret = -EEXIST;
> +	else
> +		list_add(&tt->list, &_targets);
> +	up_write(&_lock);
> +
> +	return ret;
> +}
> +
> +void nvm_unregister_target(struct nvm_target_type *tt)
> +{
> +	if (!tt)
> +		return;
> +
> +	down_write(&_lock);
> +	list_del(&tt->list);
> +	up_write(&_lock);
> +}

Trying to build rrpc.ko I saw this
    WARNING: "nvm_unregister_target" [[...]/drivers/lightnvm/rrpc.ko] undefined!
    WARNING: "nvm_register_target" [[...]/drivers/lightnvm/rrpc.ko] undefined!

So I guess you need to export these two functions too.

> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -209,6 +209,9 @@ struct request {
>  
>  	/* for bidi */
>  	struct request *next_rq;
> +#if CONFIG_BLK_DEV_NVM

Again, I think
    #ifdef CONFIG_BLK_DEV_NVM

> +	sector_t phys_sector;
> +#endif
>  };
>  
>  static inline unsigned short req_get_ioprio(struct request *req)


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/