linux-kernel - Re: [RFC 0/6] perf tools: Report event parsing errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 18 Apr 2015 19:39:27 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	David Ahern <dsahern@...il.com>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [RFC 0/6] perf tools: Report event parsing errors


* Jiri Olsa <jolsa@...nel.org> wrote:

> hi,
> adding support to report error from event string parsing.

Very nice!

> This patchset contains support for standard parsing errors and more 
> logic to recognize tracepoint and 'pmu//' terms, like:
> 
>   $ perf record -e 'sched:krava' ls
>   invalid or unsupported event: 'sched:krava'
>                                  \___ unknown tracepoint
> 
>   $ ./perf record -e 'cpu/even=0x1/' ls
>   invalid or unsupported event: 'cpu/even=0x1/'
>                                      \___ unknown term
> 
>   $ perf record -e cycles,cache-mises ls
>   invalid or unsupported event: '..es,cache-mises'
>                                            \___ parser error
> 
> any feedback about the error string shape would be great ;-)

So since we now know exactly what's going on, we might want to drop 
the 'invalid or unsupported event' language as well, and make it 
specific:

   $ ./perf record -e 'cpu/even=0x1/' ls
   event syntax error: 'cpu/even=0x1/'
                            \___ unknown term
 

?

Also, for the above error, could we easily list the valid terms? An 
error like:

   $ ./perf record -e 'cpu/even=0x1/' ls
   event syntax error: 'cpu/even=0x1/'
                            \___ unknown term
   valid terms: "event", "raw".

or so?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/