linux-kernel - Re: Input: tca8418-keypad: Incorrect values in a driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 20 Apr 2015 18:11:33 +0200
From:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
To:	"Valdez, Jonathan" <j.valdez@...com>
CC:	dmitry.torokhov@...il.com, kyle.manna@...l7.com, hns@...delico.com,
	linux-input@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Input: tca8418-keypad: Incorrect values in a driver

Hi Jonathan,

Thank you for reporting this issue!

On 03/30/2015 06:41 PM, Valdez, Jonathan wrote:
>
> Hello,
>
>  
>
> I’ve been supporting the TCA8418 and have been pointed to your
> document by a few customers
> (http://lxr.free-electrons.com/source/drivers/input/keyboard/tca8418_keypad.c)
>
>  
>
>  
>
> The problem I am seeing is that you are writing a 1 to
> REG_DEBOUNCE_DIS1/2/3, which actually disables column debouncing. A 0
> enables it. This is easily fixed, but I wanted to bring this to your
> attention.
>
>  
>
> Please see page 19 of the TCA8418 datasheet, where the registers are
> debounce_DIS(able) registers. A 0 keeps debouncing enabled. By default
> debounce is enabled.
>
>  
>
> Best regards,
>
> Jonathan Valdez
>
> System Connectivity Applications
>

I'm not the maintainer of this code though, just showing the source code
on our LXR webste. I'm CCing the guys in charge.

Cheers,

Michael.

-- 
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/