linux-kernel - revert c72c6160d967ed26a0b136dbab337f821d233509

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 22 Apr 2015 18:58:37 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Minchan Kim <minchan@...nel.org>, Nitin Gupta <ngupta@...are.org>,
	linux-kernel@...r.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: revert c72c6160d967ed26a0b136dbab337f821d233509

Hello,

could you please revert c72c6160d967ed26a0b136dbab337f821d233509 ?

Commit c72c6160d967 ("zram: move compact_store() to sysfs functions area")
was intended to be a cosmetic change that w/o any functional change and was
part of a bigger change:
  http://lkml.iu.edu/hypermail/linux/kernel/1503.1/01818.html

(so c72c6160d967 removes compaction support).

my bad, we managed to create a mess of patches for 4.1, so Andrew had to
manually pick up and alter some commits. it didn't work well for that one.

so we can either add missing compaction sysfs attr, or revert this change.
Minchan Kim and I prefer to revert this commit
  http://lkml.iu.edu/hypermail/linux/kernel/1504.2/00623.html

since it doesn't add any value to 4.1 per se.

I will re-submit it for 4.2 (along with the above mentioned bigger change).

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/