linux-kernel - Re: [tpmdd-devel] [PATCH v2] tpm: enable PPI for TPM 2.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Apr 2015 20:10:24 +0200
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Simon Wunderlich <sw@...onwunderlich.de>,
	NeilBrown <neilb@...e.de>, linux-kernel@...r.kernel.org,
	Jianyu Zhan <nasa4836@...il.com>,
	Andrzej Hajda <a.hajda@...sung.com>,
	tpmdd-devel@...ts.sourceforge.net,
	Al Viro <viro@...iv.linux.org.uk>, Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Guenter Roeck <linux@...ck-us.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [tpmdd-devel] [PATCH v2] tpm: enable PPI for TPM 2.0

On Wed, Apr 22, 2015 at 11:22:43AM -0600, Jason Gunthorpe wrote:
> On Wed, Apr 22, 2015 at 07:38:55PM +0300, Jarkko Sakkinen wrote:
> > > > > +EXPORT_SYMBOL_GPL(kernfs_remove_by_name_ns);
> > > > 
> > > > ??
> > > > I don't see this being called
> > > 
> > > My bad, it is clutter in the patch file. I'll remove it.
> > 
> > In fact this is needed because the driver uses kernfs_remove_by_name,
> > which is an inline function that uses kernfs_remove_by_name_ns
> > internally.
> 
> Hum, that probably needs a sysfs_ analog - the paired removal
> function for sysfs_link_group_to_kobj ?

Be very careful using that sysfs function, you shouldn't be doing that
within a driver subsystem unless you know what you are doing :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/