linux-kernel - Re: [PATCH 1/2] powerpc/powernv: Add definition of OPAL_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Apr 2015 16:54:01 +0530
From:	Preeti U Murthy <preeti@...ux.vnet.ibm.com>
To:	Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH 1/2] powerpc/powernv: Add definition of OPAL_MSG_OCC message
 type

Hi Shilpa,

On 04/22/2015 10:34 PM, Shilpasri G Bhat wrote:
> Add OPAL_MSG_OCC message definition to opal_message_type to notify OCC

s/notify OCC events/receive OCC events ?

> events like reset, load and throttled. Host performance can be
> affected when OCC is reset or OCC throttles the max Pstate.
> We can register to opal_message_notifier to receive OPAL_MSG_OCC type
> of message.

You may want to mention that we register to receive this message so as
to report to userspace about the same. The purpose of this patchset is
reporting so as to keep the user informed about the reason for a
performance drop in workloads.

> 
> The reset and load OCC events are notified to kernel when FSP sends
> OCC_RESET and OCC_LOAD commands.  Both reset and load messages are
> sent to kernel on successful completion of reset and load operation
> respectively.
> 
> The throttle OCC event indicates that the Pmax of the chip is reduced.
> The chip_id and throttle reason for reducing Pmax is also queued along
> with the message.
> 
> Additional opal message type OPAL_MSG_PRD is added to maintain
> compatibility between opal and kernel definition of opal_message_type.
> 
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>
> ---
>  arch/powerpc/include/asm/opal-api.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/powerpc/include/asm/opal-api.h b/arch/powerpc/include/asm/opal-api.h
> index 0321a90..50053b7 100644
> --- a/arch/powerpc/include/asm/opal-api.h
> +++ b/arch/powerpc/include/asm/opal-api.h
> @@ -352,6 +352,14 @@ enum opal_msg_type {
>  	OPAL_MSG_SHUTDOWN,		/* params[0] = 1 reboot, 0 shutdown */
>  	OPAL_MSG_HMI_EVT,
>  	OPAL_MSG_DPO,
> +	OPAL_MSG_PRD,
> +	OPAL_MSG_OCC,                   /*
> +					 * params[0] = 0 reset,
> +					 *             1 load,
> +					 *             2 throttle
> +					 * params[1] = chip_id
> +					 * params[2] = throttle_status
> +					 */
>  	OPAL_MSG_TYPE_MAX,
>  };

Besides the above nit, the patch looks good.

Reviewed-by: Preeti U Murthy <preeti@...ux.vnet.ibm.com>
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/