linux-kernel - Re: [PATCH 2/2] Input - synaptics: pin 3 touches when the firmware reports 3 fingers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Apr 2015 13:48:29 -0400
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Henrik Rydberg <rydberg@...math.org>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Hutterer <peter.hutterer@...-t.net>,
	Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH 2/2] Input - synaptics: pin 3 touches when the firmware
 reports 3 fingers

Hi Henrik,

On Apr 25 2015 or thereabouts, Henrik Rydberg wrote:
> Benjamin,
> 
> >>>> For old kernels this is not a problem because max_slots was 2 and libinput/
> >>>> xorg-synaptics knew how to deal with that. Now that max_slot is 3, the
> >>>> clients ignore BTN_TOOL_TRIPLETAP and count the actual used slots (so 2).
> >>>> It then gets confused when receiving the BTN_TOOL_TRIPLETAP and DOUBLETAP
> >>>> information, and goes wild.
> 
> Maybe the cr48 sensor should be classified as MT_SEMI instead.
> 

That's not a cr48 issue (actually the cr48 is also affected given that
it allocates 2 slots). To be able to fix the cursors jumps that we see
with any regular image sensor touchpad, I cleaned up all the code and
relied on the kernel tracking to provide an actual tracking. So now,
either the touchpad is old and it does forwards SEMI_MT, either it is
new enough and uses the in-kernel tracking.

Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/