linux-kernel - Re: [PATCH] earlycon: Fix uart_parse_earlycon() if !CONFIG_SERIAL_CORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Apr 2015 14:22:10 +0200
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	Jiri Slaby <jslaby@...e.cz>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>, tfiga@...gle.com,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] earlycon: Fix uart_parse_earlycon() if
 !CONFIG_SERIAL_CORE_CONSOLE

On Sat, Apr 11, 2015 at 10:42:36AM -0400, Peter Hurley wrote:
> Arnd Bergmann wrote:
> > A configuration that enables earlycon but not the core console
> > code causes a link error:
> >
> > drivers/built-in.o: In function `setup_earlycon':
> > drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon'
> 
> CONFIG_SERIAL_EARLYCON should not require CONFIG_SERIAL_CORE_CONSOLE.
> Move uart_parse_earlycon() and compile if either CONFIG_SERIAL_CORE_CONSOLE
> or CONFIG_SERIAL_EARLYCON.
> 
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Peter Hurley <peter@...leysoftware.com>
> ---
> 
> NB: The diff moves everything else around uart_parse_earlycon() :/
> 
>  drivers/tty/serial/serial_core.c | 90 ++++++++++++++++++++--------------------
>  1 file changed, 46 insertions(+), 44 deletions(-)

This doesn't apply to my tty-next branch :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/