linux-kernel - Re: [PATCH 2/2] [PATCH] sched: Add smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Apr 2015 16:33:57 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	Manfred Spraul <manfred@...orfullife.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Kirill Tkhai <ktkhai@...allels.com>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Chris Metcalf <cmetcalf@...hip.com>
Subject: Re: [PATCH 2/2] [PATCH] sched: Add smp_rmb() in task rq locking
 cycles

On Sun, Apr 26, 2015 at 03:52:13AM -0700, Paul E. McKenney wrote:

> And then an smp_read_barrier_depends() would be needed either here
> or embedded in apin_unlock_wait().  But we also need to check the
> spin_unlock_wait() implementations to see if any are potentially
> vulnerable to compiler misbehavior due to lack of ACCESS_ONCE(),
> READ_ONCE(), or other sources of the required volatility:
> 

> o	tile: For 32-bit, looks like a bug.  Compares ->current_ticket and
> 	->next_ticket with no obvious protection.  The compiler is free to
> 	load them in either order, so it is possible that the two fields
> 	could compare equal despite never having actually been equal at
> 	any given time.  Needs something like arm, arm64, mips, or x86
> 	to do single fetch, then compare fields in quantity fetched.
> 
> 	Except that this appears to be using int on a 32-bit system,
> 	thus might not have a 64-bit load.  If that is the case, the
> 	trick would be to load them in order.  Except that this can be
> 	defeated by overflow.  Are there really 32-bit tile systems with
> 	enough CPUs to overflow an unsigned short?
> 
> 	For 64-bit, a READ_ONCE() appears to be in order -- no obvious
> 	volatility present.
> 

Chris?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/