linux-kernel - Re: [PATCHv3 06/11] usb: dwc3: soft reset to it's own function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Apr 2015 12:22:51 -0500
From:	Felipe Balbi <balbi@...com>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
CC:	Felipe Balbi <balbi@...com>,
	David Cohen <david.a.cohen@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Baolu Lu <baolu.lu@...ux.intel.com>,
	Paul Bolle <pebolle@...cali.nl>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3 06/11] usb: dwc3: soft reset to it's own function

On Tue, Apr 28, 2015 at 04:24:41PM +0300, Heikki Krogerus wrote:
> So it can be called from other places later.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Acked-by: David Cohen <david.a.cohen@...ux.intel.com>
> ---
>  drivers/usb/dwc3/core.c | 46 ++++++++++++++++++++++++++++++----------------
>  1 file changed, 30 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 104b236..921f181 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -117,6 +117,33 @@ static int dwc3_core_soft_reset(struct dwc3 *dwc)
>  }
>  
>  /**
> + * dwc3_soft_reset - Issue soft reset
> + * @dwc: Pointer to our controller context structure
> + */
> +static int dwc3_soft_reset(struct dwc3 *dwc)

I don't see this being called anywhere else in your series and I would
really like to know when we would need to reset the core again ?

I don't oppose to having this split to own function because I rather
like how it looks, but I don't want to reset the IP needlessly either.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)