linux-kernel - Re: [PATCH] usb: dwc2: gadget: cleanup useless code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Apr 2015 22:58:22 +0000
From:	John Youn <John.Youn@...opsys.com>
To:	Yunzhi Li <lyz@...k-chips.com>,
	"John.Youn@...opsys.com" <John.Youn@...opsys.com>,
	"gregory.herrero@...el.com" <gregory.herrero@...el.com>,
	"yousaf.kaukab@...el.com" <yousaf.kaukab@...el.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"balbi@...com" <balbi@...com>
CC:	"linux-rockchip@...ts.infradead.org" 
	<linux-rockchip@...ts.infradead.org>,
	"rockchip-discuss@...omium.org" <rockchip-discuss@...omium.org>
Subject: Re: [PATCH] usb: dwc2: gadget: cleanup useless code

On 4/28/2015 3:50 PM, John Youn wrote:
> On 4/26/2015 12:36 AM, Yunzhi Li wrote:
>> dwc2 gadget driver s3c_hsotg_of_probe() run twice in
>> dwc2_gadget_init() and the first one is useless, so remove it.
>>
>> Signed-off-by: Yunzhi Li <lyz@...k-chips.com>
>> ---
>>  drivers/usb/dwc2/gadget.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
>> index 6a30887..2ae74f2 100644
>> --- a/drivers/usb/dwc2/gadget.c
>> +++ b/drivers/usb/dwc2/gadget.c
>> @@ -3851,8 +3851,6 @@ int dwc2_gadget_init(struct dwc2_hsotg *hsotg, int irq)
>>  	/* Set default UTMI width */
>>  	hsotg->phyif = GUSBCFG_PHYIF16;
>>  
>> -	s3c_hsotg_of_probe(hsotg);
>> -
>>  	/* Initialize to legacy fifo configuration values */
>>  	hsotg->g_rx_fifo_sz = 2048;
>>  	hsotg->g_np_g_tx_fifo_sz = 1024;
>>
> 
> 
> Acked-by: John Youn <johnyoun@...opsys.com>
> 

Added Felipe.

John

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/