linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: Add msm8916 CoreSight components

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Apr 2015 07:03:31 -0600
From:	Mathieu Poirier <mathieu.poirier@...aro.org>
To:	"Ivan T. Ivanov" <ivan.ivanov@...aro.org>
Cc:	Kumar Gala <galak@...eaurora.org>,
	Pratik Patel <pratikp@...eaurora.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add msm8916 CoreSight components

On 30 April 2015 at 03:24, Ivan T. Ivanov <ivan.ivanov@...aro.org> wrote:
>
> On Wed, 2015-04-29 at 10:49 -0600, Mathieu Poirier wrote:
>> On 29 April 2015 at 06:20, Ivan T. Ivanov ivanov@...aro.org> wrote:
>
>
>> > +
>> > +       funnel@...000 {
>> > +               compatible = "arm,coresight-funnel", "arm,primecell";
>> > +               reg = <0x821000 0x1000>;
>> > +
>> > +               clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
>> > +               clock-names = "apb_pclk", "atclk";
>> > +
>> > +               ports {
>> > +                       #address-cells = <1>;
>> > +                       #size-cells = <0>;
>> > +
>> > +                       port@4 {
>> > +                               reg = <4>;
>> > +                               funnel0_in4: endpoint {
>> > +                                       slave-mode;
>> > +                                       remote-endpoint = <&funnel1_out>;
>> > +                               };
>> > +                       };
>> > +                       port@8 {
>> > +                               reg = <0>;
>> > +                               funnel0_out: endpoint {
>> > +                                       remote-endpoint = <&etf_in>;
>> > +                               };
>> > +                       };
>>
>> Please add a comment indicating what the other ports are connected to.
>>
>> > +               };
>> > +       };
>> > +
>> > +       replicator@...000 {
>> > +               compatible = "qcom,coresight-replicator", "arm,primecell";
>> > +               reg = <0x824000 0x1000>;
>> > +
>> > +               clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
>> > +               clock-names = "apb_pclk", "atclk";
>> > +
>> > +               ports {
>> > +                       #address-cells = <1>;
>> > +                       #size-cells = <0>;
>> > +
>> > +                       port@0 {
>> > +                               reg = <0>;
>> > +                               replicator_out0: endpoint {
>> > +                                       remote-endpoint = <&etr_in>;
>> > +                               };
>> > +                       };
>> > +                       port@1 {
>> > +                               reg = <1>;
>> > +                               replicator_out1: endpoint {
>> > +                                       remote-endpoint = <&tpiu_in>;
>> > +                               };
>> > +                       };
>> > +                       port@2 {
>> > +                               reg = <0>;
>> > +                               replicator_in: endpoint {
>> > +                                       slave-mode;
>> > +                                       remote-endpoint = <&etf_out>;
>> > +                               };
>> > +                       };
>>
>> Same comment as with the funnel component.
>
> Sorry, but what do you mean here?

My bad - replicators have only one input port and two output ones.
Forget about this comments.

>
> Regards,
> Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/