linux-kernel - Re: [PATCH 1/3] ASoC: Add gtm601 codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 May 2015 13:36:48 +0200
From:	Belisko Marek <marek.belisko@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	perex@...ex.cz, tiwai@...e.de,
	"Dr. H. Nikolaus Schaller" <hns@...delico.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, alsa-devel@...a-project.org
Subject: Re: [PATCH 1/3] ASoC: Add gtm601 codec driver

Hi Mark,

On Fri, May 1, 2015 at 1:03 PM, Mark Brown <broonie@...nel.org> wrote:
> On Thu, Apr 30, 2015 at 11:28:01PM +0200, Marek Belisko wrote:
>
>>       select SND_SOC_WM9705 if SND_SOC_AC97_BUS
>>       select SND_SOC_WM9712 if SND_SOC_AC97_BUS
>>       select SND_SOC_WM9713 if SND_SOC_AC97_BUS
>> +     select SND_SOC_GTM601
>>          help
>> +config SND_SOC_GTM601
>> +     tristate 'GTM601 UMTS modem audio codec'
>> +
>
> Keep Makefile and Kconfig sorted.
Ok.
>
>> +/*
>> + * Note this is a simple chip with no configuration interface, sample rate is
>> + * determined automatically by examining the Master clock and Bit clock ratios
>> + */
>
>> +#define GTM601_RATES  (SNDRV_PCM_RATE_8000)
>
> Does it or doesn't it support multiple sample rates?
It support only 8kHz rate. I'll remove define and use SNDRV_PCM_RATE_8000
only in gtm601_dai struct.

Thanks and BR.

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/