linux-kernel - Re: [PATCH] hpfs: Remove unessary cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 May 2015 09:30:34 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mikulas Patocka <mikulas@...bright.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Firo Yang <firogm@...il.com>
Subject: Re: [PATCH] hpfs: Remove unessary cast

Mikulas, when forwarding patches from others, you also need to add that

   "From: Firo Yang <firogm@...il.com>"

at the top (and it can be nice if you also add the date-line).
Otherwise authorship gets lost.

Sign-off lines _normally_ show the whole authorship chain too, but no,
it's not enough to just have the sign-off line there.

                     Linus

On Sat, May 2, 2015 at 1:10 AM, Mikulas Patocka <mikulas@...bright.com> wrote:
> Avoid a pointless kmem_cache_alloc() return value cast in
> fs/hpfs/super.c::hpfs_alloc_inode()
>
> Signed-off-by: Firo Yang <firogm@...il.com>
> Acked-by: Mikulas Patocka <mikulas@...bright.com>
>
>
> ---
> fs/hpfs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
> diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
> index 7cd00d3..ccace08 100644
> --- a/fs/hpfs/super.c
> +++ b/fs/hpfs/super.c
> @@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;
> static struct inode *hpfs_alloc_inode(struct super_block *sb)
> {
>         struct hpfs_inode_info *ei;
> -       ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep,
> GFP_NOFS);
> +       ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
>         if (!ei)
>                 return NULL;
>         ei->vfs_inode.i_version = 1;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/