linux-kernel - Re: [PATCH v2 0/9] x86: remove cpu_**

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 May 2015 13:22:45 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Jean Delvare <jdelvare@...e.de>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Benoit Cousson <bcousson@...libre.com>,
	Jonathan Corbet <corbet@....net>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Russell King <linux@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>
Subject: Re: [PATCH v2 0/9] x86: remove cpu_**_mask() functions


* Bartosz Golaszewski <bgolaszewski@...libre.com> wrote:

> Two functions defined in asm/smp.h: cpu_sibling_mask() and cpu_core_mask(),
> have the same functionality as macros defined in linux/topology.h:
> topology_thread_cpumask() and topology_core_cpumask() respectively.
> 
> They are not documented and are architecture specific. Also: different
> naming for the same functionality (in case of cpu_sibling_mask() and
> topology_thread_cpumask()) is a bit misleading.
> 
> This series makes all the callers switch to using the topology.h macros
> and removes their smp.h counterparts. While we're at it: rename
> topology_thread_cpumask() to topology_sibling_cpumask() to be
> consistent with the term used in the scheduler.
> 
> The same duplication exists on powerpc.
> 
> NOTE: patch 2/9 had been already submitted separately but didn't
> receive any attention, so I'm attaching it to this series.
> 
> v2:
> - renamed topology_thread_cpumask() to topology_sibling_cpumask()
> - updated Documentation/cputopology.txt
> 
> v1:
> https://lkml.org/lkml/2015/4/30/188
> 
> Bartosz Golaszewski (9):
>   topology: rename topology_thread_cpumask()
>   Documentation: update cputopology.txt
>   coretemp: replace cpu_sibling_mask() with topology_sibling_cpumask()
>   powernow-k8: replace cpu_core_mask() with topology_core_cpumask()
>   p4-clockmod: replace cpu_sibling_mask() with topology_sibling_cpumask()
>   acpi-cpufreq: replace cpu_**_mask() with topology_**_cpumask()
>   speedstep-ich: replace cpu_sibling_mask() with topology_sibling_cpumask()
>   x86: replace cpu_**_mask() with topology_**_cpumask()
>   x86: remove cpu_sibling_mask() and cpu_core_mask()

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/