| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 May 2015 16:17:41 +0100 From: Al Viro <viro@...IV.linux.org.uk> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Neil Brown <neilb@...e.de>, Christoph Hellwig <hch@...radead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-fsdevel <linux-fsdevel@...r.kernel.org> Subject: Re: [PATCH 40/79] link_path_walk: turn inner loop into explicit goto On Tue, May 05, 2015 at 08:09:04AM -0700, Linus Torvalds wrote: > On Mon, May 4, 2015 at 10:22 PM, Al Viro <viro@...iv.linux.org.uk> wrote: > > +l: > > This looked like noise. > > PLEASE. We're not programming in Pascal (and thank all Gods for that), > so we can have labels that have meaningful names. Also, we're not > ashamed of using goto where it makes sense, so we don't need to try to > hide the labels by making them look like specks of dirt on our > monitor. > > So give the label a real name that describes what it is. Not this kind of thing. Something like this_used_to_be_the_beginning_of_loop_body? Seriously, it's strictly temporary thing - it lives for two commits and gets killed after that. Exactly because it has no good inherent meaning. The label replacing it two commits later (several lines upstream) does, and it gets better name... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists