linux-kernel - Re: [PATCH] iio: mcp320x: Fix occasional incorrect readings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 05 May 2015 19:29:43 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Michael Welling <mwelling@...e.org>, jic23@...nel.org,
	knaack.h@....de, pmeerw@...erw.net, san@...etechnology.dk,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: mcp320x: Fix occasional incorrect readings

On 05/05/2015 06:29 PM, Michael Welling wrote:
> Without the cacheline alignment, the readings will occasionally incorrectly
> return 0.
>
> Signed-off-by: Michael Welling <mwelling@...e.org>
> ---
>   drivers/iio/adc/mcp320x.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index efbfd12..46b98cf 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -60,7 +60,7 @@ struct mcp320x {
>   	struct spi_message msg;
>   	struct spi_transfer transfer[2];
>
> -	u8 tx_buf;
> +	u8 tx_buf ____cacheline_aligned;
>   	u8 rx_buf[2];

The buffers should probably be moved at the end, e.g. reg will still be on 
the same cacheline.

>
>   	struct regulator *reg;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/