linux-kernel - Re: [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 May 2015 13:31:08 -0400
From:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:	David Vrabel <david.vrabel@...rix.com>, konrad.wilk@...cle.com,
	hpa@...or.com, mingo@...hat.com, tglx@...utronix.de
CC:	linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
	linux@...elenboom.it, luto@...capital.net
Subject: Re: [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS
 on Xen PV guests

On 05/05/2015 01:25 PM, David Vrabel wrote:
> On 04/05/15 16:02, Boris Ostrovsky wrote:
>> --- a/arch/x86/xen/enlighten.c
>> +++ b/arch/x86/xen/enlighten.c
>> @@ -1760,6 +1760,9 @@ static struct notifier_block xen_hvm_cpu_notifier = {
>>   
>>   static void __init xen_hvm_guest_init(void)
>>   {
>> +	if (xen_pv_domain())
>> +		return;
>> +
> I take Andy's point that this looks a little odd, perhaps...
>
> static void __init xen_platform_init(void)
> {
>      if (!xen_pv_domain())
>          xen_hvm_guest_init();
> }
>
> Would be a useful follow up?
>
> I'll apply as-is though
>


Yes, this would look better. I can respin this if you want to avoid the 
extra patch.

-boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/