linux-kernel - Re: [PATCH v2] perf kmem: Show warning when trying to run stat without record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 May 2015 17:16:29 +0300
From:	Pekka Enberg <penberg@....fi>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>
CC:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Joonsoo Kim <js1304@...il.com>,
	Minchan Kim <minchan@...nel.org>,
	Pekka Enberg <penberg@...nel.org>, linux-mm@...ck.org
Subject: Re: [PATCH v2] perf kmem: Show warning when trying to run stat without
 record

On 05/05/2015 05:07 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 05, 2015 at 09:58:12AM +0900, Namhyung Kim escreveu:
>> Sometimes one can mistakenly run perf kmem stat without perf kmem
>> record before or different configuration like recoding --slab and stat
>> --page.  Show a warning message like below to inform user:
>>
>>    # perf kmem stat --page --caller
>>    Not found page events.  Have you run 'perf kmem record --page' before?
>>
>> Acked-by: Pekka Enberg <penberg@...nel.org>
>> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> Thanks, applied.
>
> I just found the messages a bit odd souding, perhaps:
>
>     # perf kmem stat --page --caller
>     No page allocation events found.  Have you run 'perf kmem record --page'?
>
> Pekka?

Sure, that sounds less confusing.

- Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/