linux-kernel - RE: [PATCH 2/4] x86/mce/amd: Introduce deferred error interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 20:28:29 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>,
	Borislav Petkov <bp@...en8.de>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"jiang.liu@...ux.intel.com" <jiang.liu@...ux.intel.com>,
	"yinghai@...nel.org" <yinghai@...nel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"dvlasenk@...hat.com" <dvlasenk@...hat.com>,
	"JBeulich@...e.com" <JBeulich@...e.com>,
	"slaoub@...il.com" <slaoub@...il.com>,
	"luto@...capital.net" <luto@...capital.net>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"oleg@...hat.com" <oleg@...hat.com>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"rusty@...tcorp.com.au" <rusty@...tcorp.com.au>,
	"prarit@...hat.com" <prarit@...hat.com>,
	"linux@...musvillemoes.dk" <linux@...musvillemoes.dk>,
	"jroedel@...e.de" <jroedel@...e.de>,
	"andriy.shevchenko@...ux.intel.com" 
	<andriy.shevchenko@...ux.intel.com>,
	"macro@...ux-mips.org" <macro@...ux-mips.org>,
	"wangnan0@...wei.com" <wangnan0@...wei.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	Robert Richter <rric@...nel.org>
Subject: RE: [PATCH 2/4] x86/mce/amd: Introduce deferred error interrupt
 handler

Should you check whether the address is valid before blindly reading the register?

>             m.bank = bank;
	if (m.status & MCI_STATUS_ADDRV)
         		rdmsrl(MSR_IA32_MCx_ADDR(bank), m.addr);
>             mce_log(&m);

-Tony