linux-kernel - Re: [PATCH 1/2] x86/quark: Add Quark embedded SRAM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 May 2015 15:19:25 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	"Bryan O'Donoghue" <pure.logic@...us-software.ie>
CC:	mingo@...hat.com, x86@...nel.org, dvhart@...radead.org,
	andy.schevchenko@...il.com, boon.leong.ong@...el.com,
	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	derek.browne@...el.com, josef.ahmad@...el.com,
	erik.nyquist@...el.com
Subject: Re: [PATCH 1/2] x86/quark: Add Quark embedded SRAM support

On 05/04/2015 08:00 AM, Thomas Gleixner wrote:
> 
>> + */
>> +static int esram_dbgfs_state_show(struct seq_file *s, void *unused)
>> +{
>> +	struct esram_dev *edev = &esram_dev;
>> +	u32 data;
>> +	u32 reg = (u32)s->private;
> 
> You really like to waste lines. What's wrong with:
> 
>     	u32 data, reg = .....
> 

I have to say I agree with Bryan here: it is rather ugly to mix
uninitialized and initialized variables on the same declaration line.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/