linux-kernel - Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 11:54:39 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Gwendal Grignou <gwendal@...omium.org>,
	Olof Johansson <olof@...om.net>,
	Doug Anderson <dianders@...omium.org>,
	Bill Richardson <wfrichar@...omium.org>,
	Simon Glass <sjg@...gle.com>,
	Stephen Barber <smbarber@...omium.org>,
	Filipe Brandenburger <filbranden@...gle.com>,
	Todd Broch <tbroch@...omium.org>,
	linux-samsung-soc@...r.kernel.org,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field

On Tue, 05 May 2015, Javier Martinez Canillas wrote:
> On 04/29/2015 12:37 PM, Lee Jones wrote:
> > On Thu, 23 Apr 2015, Gwendal Grignou wrote:
> > 
> >> Be consistent, use cros_ec instead of "cros ec" or "cros-ec".
> > 
> > What is this in reference to?
> >
> 
> I think Gwendal meant that I should be consistent in general and was not
> referring to this patch particular.

Better to quote one of the offending occurrences than to randomly
top-post helpful comments.

> >> Otherwise:
> >> 
> >> Reviewed-by: Gwendal Grignou <gwendal@...omium.org>
> >> Tested-by: Gwendal Grignou <gwendal@...omium.org>
> >> 
> >> On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas
> >> <javier.martinez@...labora.co.uk> wrote:
> >> > From: Gwendal Grignou <gwendal@...omium.org>
> >> >
> >> > parent and dev were pointing to the same device structure.
> >> > parent is unused, removed.
> >> >
> >> > Signed-off-by: Gwendal Grignou <gwendal@...omium.org>
> >> > Reviewed-by: Stephen Barber <smbarber@...omium.org>
> >> > Tested-by: Stephen Barber <smbarber@...omium.org>
> >> > Reviewed-by: Puthikorn Voravootivat <puthik@...omium.org>
> >> > Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
> >> > ---
> >> >  drivers/mfd/cros_ec_i2c.c             | 1 -
> >> >  drivers/mfd/cros_ec_spi.c             | 1 -
> >> >  drivers/platform/chrome/cros_ec_lpc.c | 1 -
> >> >  include/linux/mfd/cros_ec.h           | 2 --
> >> >  4 files changed, 5 deletions(-)
> > 
> > For when you re-submit:
> > 
> > Acked-by: Lee Jones <lee.jones@...aro.org>
> > 
> 
> Thanks a lot for your ack.
> 
> Best regards,
> Javier

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/