linux-kernel - Re: [PATCH 04/27] extcon: Allow compile test of GPIO consumers if !GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 May 2015 14:38:14 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Arnd Bergmann <arnd@...db.de>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	MyungJoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH 04/27] extcon: Allow compile test of GPIO consumers if
 !GPIOLIB

Hi Geert,

On 05/06/2015 01:32 AM, Geert Uytterhoeven wrote:
> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
> 
> Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where
> appropriate.
> 
> If GPIOLIB=n and asm-generic/gpio.h is not used:
> 
>     drivers/extcon/extcon-usb-gpio.c: In function ‘usb_extcon_detect_cable’:
>     drivers/extcon/extcon-usb-gpio.c:63: error: implicit declaration of function ‘gpiod_get_value_cansleep’
>     drivers/extcon/extcon-usb-gpio.c: In function ‘usb_extcon_probe’:
>     drivers/extcon/extcon-usb-gpio.c:116: error: implicit declaration of function ‘devm_gpiod_get’
>     drivers/extcon/extcon-usb-gpio.c:116: warning: assignment makes pointer from integer without a cast
>     drivers/extcon/extcon-usb-gpio.c:122: error: implicit declaration of function ‘gpiod_set_debounce’
>     drivers/extcon/extcon-usb-gpio.c:129: error: implicit declaration of function ‘gpiod_to_irq’
> 
> Add the missing #include <linux/gpio/consumer.h> to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> ---
>  drivers/extcon/Kconfig           | 4 ++--
>  drivers/extcon/extcon-usb-gpio.c | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)

Applied it on -next branch.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/