linux-kernel - Re: Why isn't IRQ shared for i2c-ocore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 May 2015 08:01:49 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	York Sun <yorksun@...escale.com>
Cc:	Julia.Lawall@...6.fr, linux-i2c@...r.kernel.org,
	wolfram@...-dreams.de, linux-kernel@...r.kernel.org
Subject: Re: Why isn't IRQ shared for i2c-ocore

> I have a follow up question regarding interrupt. I see many I2C bus drivers
> request interrupt with flag = 0. Why not using IRQF_SHARED?

Probably because that particular IRQ is only used by the I2C
Controller.  I'm not exactly sure that you're getting at?  Why do you
think it should be shared?  You should only flag it as shared if it
is.

> I understand the performance concern. If there is any other reason, I want to
> know about it before I go too far on my driver.

This sort of stuff is trivial to fix and shouldn't stand in the way
of you writing and submitting v1 of your driver.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/