linux-kernel - Re: [HPDD-discuss] [PATCH] staging: lustre: code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 May 2015 15:09:08 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Dilger, Andreas" <andreas.dilger@...el.com>
Cc:	Mike Shuey <shuey@...due.edu>,
	"Drokin, Oleg" <oleg.drokin@...el.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"HPDD-discuss@...ts.01.org" <HPDD-discuss@...1.01.org>
Subject: Re: [HPDD-discuss] [PATCH] staging: lustre: code cleanup - variable
 declaration spacing

On Thu, May 07, 2015 at 03:36:05AM +0000, Dilger, Andreas wrote:
> On 2015/05/06, 6:02 AM, "Mike Shuey" <shuey@...due.edu> wrote:
> 
> >Clean up spacing in some variable declarations, to be more consistent.
> >
> >It's small, but I need to start somewhere.  Please let me know if I'm not
> >adhering to proper procedure for trivial cleanups.
> 
> It's actually Lustre coding style to align the variable declarations.
> Is this something that causes checkpatch.pl to complain?  If not, I'd
> prefer not to change all of these declarations, since it causes a lot
> of code churn for very little benefit.

In theory it's nice, but in reality aligning variables doesn't work in
.c files.  If you look at the patch, almost every declaration block uses
higgledy piggledy alignment.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/