linux-kernel - Re: [STLinux Kernel] [PATCH 06/12] watchdog: bindings: Supply knowledge of a third supported device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 May 2015 20:19:09 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Peter Griffin <peter.griffin@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, kernel@...inux.com,
	rtc-linux@...glegroups.com, a.zummo@...ertech.it,
	daniel.lezcano@...aro.org, wim@...ana.be, tglx@...utronix.de,
	linux@...ck-us.net, linux-watchdog@...r.kernel.org
Subject: Re: [STLinux Kernel] [PATCH 06/12] watchdog: bindings: Supply
 knowledge of a third supported device - clocksource

> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > ---
> >  Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt | 15 +++++++++------
> >  1 file changed, 9 insertions(+), 6 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt
> > index 388c88a..0b1a784 100644
> > --- a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt
> > +++ b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt
> > @@ -1,20 +1,23 @@
> >  STMicroelectronics Low Power Controller (LPC) - Watchdog
> >  ========================================================
> >  
> > -LPC currently supports Watchdog OR Real Time Clock functionality.
> > +LPC currently supports Watchdog OR Real Time Clock OR Clocksource
> > +functionality.
> >  
> >  [See: ../rtc/rtc-st-lpc.txt for RTC options]
> > +[See: ../timer/st,stih407-lpc for Clocksource options]
> >  
> >  Required properties
> >  
> > -- compatible 	: Must be one of: "st,stih407-lpc" "st,stih416-lpc"
> > -				  "st,stih415-lpc" "st,stid127-lpc"
> > +- compatible 	: Must be one of: "st,stih407-lpc"
> 
> The same comment as the RTC DT patch, you are removing the compatibles
> documentation for the other supported platforms like stih416-lpc.
> AFAIK they are required in the driver to get the correct sysconfig register.

That's intentional.  I haven't yet tested any of this IP on
STiH41{5,6} & STiH127.  Due to lack of documentation, I'm not even
sure if this IP even exists on some of the other platforms.  I will
add them back when support is added to both driver and DTB and I've
been able to test them.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/