linux-kernel - Re: [PATCH] module: Call module notifier on failure after complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 09 May 2015 03:26:18 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	stable <stable@...r.kernel.org>,
	Pontus Fuchs <pontus.fuchs@...il.com>
Subject: Re: [PATCH] module: Call module notifier on failure after complete_formation()

Steven Rostedt <rostedt@...dmis.org> writes:
> On Fri, 8 May 2015 11:17:36 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
>
>> 
>> The module notifier call chain for MODULE_STATE_COMING was moved up before
>> the parsing of args, into the complete_formation() call. But if the module failed
>> to load after that, the notifier call chain for MODULE_STATE_GOING was
>> never called and that prevented the users of those call chains from
>> cleaning up anything that was allocated.
>> 
>> Link: http://lkml.kernel.org/r/554C52B9.9060700@gmail.com
>
> You can nuke the "Link". I didn't realize Pontus didn't Cc any mailing
> lists, and I manually just added it. Usually my scripts will check if
> lkml was Cc'd and only add the "Link" tag if it was. Just shows you
> that my scripts are smarter than I am.

Thanks for this.

Applied,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/