linux-kernel - Re: [PATCH v2] staging: panel: fix stackdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 17:20:23 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Willy Tarreau <willy@...a-x.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: panel: fix stackdump

On Tue, May 12, 2015 at 02:27:13PM +0300, Dan Carpenter wrote:
> On Tue, May 12, 2015 at 04:45:44PM +0530, Sudip Mukherjee wrote:
> > if we load the module, unload and then again try to load the module, we
> > will get a stackdump. In the module_exit function we are unregistering
> > the device and releasing the parport. So when we reach the detach
> > function parport is already null and the unregister_reboot_notifier()
> > is never called. When we again try to load the module it again tries
> > register_reboot_notifier() and gives us a stackdump as its earlier
> > registration is still not removed. It was caused by the commit
> > <bb046fef9668baf1c4744a3c7aba05e15e44c9ac>.
> 
> The right format is:
> 
> commit bb046fef9668 ('staging: panel: register reboot')
> 
> It is in case human beings reading your description don't remember which
> patch bb046fef9668 was.
> 
> > Fix this by moving all the unregistering and releasing in the detach
> > function, which should be the ideal case as the detach will be called if
> > we try to unregister the driver or if the parport is removed.
> > 
> 
> We also have the Fixes: tag.
> 
> Fixes: bb046fef9668 ('staging: panel: register reboot')

ok, thanks.
I will send the v3 with the commit in correct format.

regards
sudip
> 
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> 
> regards,
> dan carpenter
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/