linux-kernel - Re: [PATCH v7 3/3] I2C: mediatek: Add driver for MediaTek MT8173 I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 15:00:57 +0200
From:	wsa@...-dreams.de
To:	Eddie Huang <eddie.huang@...iatek.com>
Cc:	Sascha Hauer <kernel@...gutronix.de>, srv_heupstream@...iatek.com,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Jean Delvare <jdelvare@...e.de>,
	David Box <david.e.box@...ux.intel.com>,
	Doug Anderson <dianders@...omium.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Max Schwarz <max.schwarz@...ine.de>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	Anders Berg <anders.berg@...gotech.com>,
	Neelesh Gupta <neelegup@...ux.vnet.ibm.com>,
	Lee Jones <lee.jones@...aro.org>,
	Arnd Bergmann <arnd@...db.de>, Ray Jui <rjui@...adcom.com>,
	Simon Glass <sjg@...omium.org>,
	Wei Yan <sledge.yanwei@...wei.com>,
	Beniamino Galvani <b.galvani@...il.com>,
	Xudong Chen <xudong.chen@...iatek.com>,
	Liguo Zhang <liguo.zhang@...iatek.com>,
	linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v7 3/3] I2C: mediatek: Add driver for MediaTek MT8173 I2C
 controller

> +	if (i2c->irq_stat & I2C_RS_TRANSFER)
> +		dev_dbg(i2c->dev, "addr: %x, restart transfer interrupt.\n",
> +				msgs->addr);

I'd tend to leave out this debug message. But you may leave it if you
like. Rest of the patch looks okay.

Thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)