linux-kernel - [PATCH v6 0/2] pci: drop msi disable on shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 15:03:10 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	Fam Zheng <famz@...hat.com>,
	Yinghai Lu <yhlu.kernel.send@...il.com>,
	Yijing Wang <wangyijing@...wei.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: [PATCH v6 0/2] pci: drop msi disable on shutdown

Fam Zheng noticed that pci shutdown disables msi and msix of a device.  This
was intended to fix kexec with fusion devices but is no longer necessary, and
can in theory be harmful.

See individual patches for the detailed explanation.

Please review, and consider for 4.2.

Eric, I would especially appreciate your feedback - I did my best
to update the commit logs with answers to questions you raised
on v5.

changes from v5:
	rebased on top of pci/msi
	fixed commit log, including comments by Bjorn
	and adding explanation to address comments/questions by Eric
	dropped stable Cc, this patch does not seem to qualify for stable
changes from v4:
        Yijing Wang <wangyijing@...wei.com> noted that
        early fixups rely on pci_msi_off.
        Split out the functionality and move off the
        required part to run early during pci_device_setup.
Changes from v3:
        fix a copy-and-paste error in
          pci: drop some duplicate code
        other patches are unchanged
        drop Cc stable for now
Changes from v2:
        move code from probe to device enumeration
        add patches to unexport pci_msi_off


Michael S. Tsirkin (2):
  PCI/MSI: Don't disable MSI/MSI-X at shutdown
  PCI/MSI: Make pci_msi_shutdown(), pci_msix_shutdown() static

 include/linux/pci.h      | 4 ----
 drivers/pci/msi.c        | 4 ++--
 drivers/pci/pci-driver.c | 2 --
 3 files changed, 2 insertions(+), 8 deletions(-)

-- 
MST

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/