linux-kernel - [tip:x86/apic] Revert f5d6a52f5111 ("x86/smpboot: Skip delays during SMP initialization similar to Xen")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 May 2015 00:15:27 -0700
From:	tip-bot for Ingo Molnar <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	mingo@...nel.org, torvalds@...ux-foundation.org, bp@...en8.de,
	arjan@...ux.intel.com, gang.wei@...el.com, tglx@...utronix.de,
	len.brown@...el.com, aliguori@...zon.com,
	linux-kernel@...r.kernel.org, jschoenh@...zon.de,
	ying.huang@...el.com, tim@....org, hpa@...or.com
Subject: [tip:x86/apic] Revert f5d6a52f5111 ("x86/smpboot:
  Skip delays during SMP initialization similar to Xen")

Commit-ID:  853b160aaafbe27d6304c8832bb7340d57c6b04e
Gitweb:     http://git.kernel.org/tip/853b160aaafbe27d6304c8832bb7340d57c6b04e
Author:     Ingo Molnar <mingo@...nel.org>
AuthorDate: Wed, 13 May 2015 08:40:49 +0200
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 13 May 2015 08:40:49 +0200

Revert f5d6a52f5111 ("x86/smpboot: Skip delays during SMP initialization similar to Xen")

Huang Ying reported x86 boot hangs due to this commit.

Turns out that the change, despite its changelog, does more
than just change timeouts: it also changes the way we
assert/deassert INIT via the APIC_DM_INIT IPI, in the x2apic
case it skips the deassert step.

This is historically fragile code and the patch did not
improve it, so revert these changes.

This commit:

  1a744cb356c5 ("x86/smp/boot: Remove 10ms delay from cpu_up() on modern processors")

independently removes the worst of the delays (the 10 msec delay).

The remaining delays can be addressed one by one, combined
with careful testing.

Reported-by: Huang Ying <ying.huang@...el.com>
Cc: Anthony Liguori <aliguori@...zon.com>
Cc: Arjan van de Ven <arjan@...ux.intel.com>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Gang Wei <gang.wei@...el.com>
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Jan H. Schönherr <jschoenh@...zon.de>
Cc: Len Brown <len.brown@...el.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Tim Deegan <tim@....org>
Link: http://lkml.kernel.org/r/1430732554-7294-1-git-send-email-jschoenh@amazon.de
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/kernel/smpboot.c | 58 ++++++++++++++++++-----------------------------
 1 file changed, 22 insertions(+), 36 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 85bd6aa..b9aaa39 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -614,34 +614,22 @@ wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
 	apic_icr_write(APIC_INT_LEVELTRIG | APIC_INT_ASSERT | APIC_DM_INIT,
 		       phys_apicid);
 
-	if (!cpu_has_x2apic) {
-		pr_debug("Waiting for send to finish...\n");
-		send_status = safe_apic_wait_icr_idle();
+	pr_debug("Waiting for send to finish...\n");
+	send_status = safe_apic_wait_icr_idle();
 
-		mdelay(init_udelay);
+	mdelay(init_udelay);
 
-		pr_debug("Deasserting INIT\n");
+	pr_debug("Deasserting INIT\n");
 
-		/* Target chip */
-		/* Send IPI */
-		apic_icr_write(APIC_INT_LEVELTRIG | APIC_DM_INIT, phys_apicid);
+	/* Target chip */
+	/* Send IPI */
+	apic_icr_write(APIC_INT_LEVELTRIG | APIC_DM_INIT, phys_apicid);
 
-		pr_debug("Waiting for send to finish...\n");
-		send_status = safe_apic_wait_icr_idle();
+	pr_debug("Waiting for send to finish...\n");
+	send_status = safe_apic_wait_icr_idle();
 
-		mb();
-		atomic_set(&init_deasserted, 1);
-	} else if (tboot_enabled()) {
-		/*
-		 * With tboot AP is actually spinning in a mini-guest before
-		 * receiving INIT. Upon receiving INIT ipi, AP need time to
-		 * VMExit, update VMCS to tracking SIPIs and VMResume.
-		 *
-		 * While AP is in root mode handling the INIT the CPU will drop
-		 * any SIPIs
-		 */
-		udelay(10);
-	}
+	mb();
+	atomic_set(&init_deasserted, 1);
 
 	/*
 	 * Should we send STARTUP IPIs ?
@@ -683,22 +671,20 @@ wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
 		apic_icr_write(APIC_DM_STARTUP | (start_eip >> 12),
 			       phys_apicid);
 
-		if (!cpu_has_x2apic) {
-			/*
-			 * Give the other CPU some time to accept the IPI.
-			 */
-			udelay(300);
+		/*
+		 * Give the other CPU some time to accept the IPI.
+		 */
+		udelay(300);
 
-			pr_debug("Startup point 1\n");
+		pr_debug("Startup point 1\n");
 
-			pr_debug("Waiting for send to finish...\n");
-			send_status = safe_apic_wait_icr_idle();
+		pr_debug("Waiting for send to finish...\n");
+		send_status = safe_apic_wait_icr_idle();
 
-			/*
-			 * Give the other CPU some time to accept the IPI.
-			 */
-			udelay(200);
-		}
+		/*
+		 * Give the other CPU some time to accept the IPI.
+		 */
+		udelay(200);
 
 		if (maxlvt > 3)		/* Due to the Pentium erratum 3AP.  */
 			apic_write(APIC_ESR, 0);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/