lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 May 2015 17:25:15 -0700 From: Benson Leung <bleung@...omium.org> To: Rhyland Klein <rklein@...dia.com> Cc: Peter De Schrijver <pdeschrijver@...dia.com>, Mike Turquette <mturquette@...aro.org>, Stephen Warren <swarren@...dotorg.org>, Stephen Boyd <sboyd@...eaurora.org>, Thierry Reding <thierry.reding@...il.com>, Alexandre Courbot <gnurou@...il.com>, Bill Huang <bilhuang@...dia.com>, Paul Walmsley <pwalmsley@...dia.com>, Jim Lin <jilin@...dia.com>, linux-clk@...r.kernel.org, linux-tegra@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v5 17/21] clk: tegra: pll: Add logic for SS On Tue, May 12, 2015 at 10:24 AM, Rhyland Klein <rklein@...dia.com> wrote: > +static void pll_clk_start_ss(struct tegra_clk_pll *pll) > +{ > + if (pll->params->defaults_set && pll->params->ssc_ctrl_en_mask) { Is there any reason you're checking for the existence of ssc_ctrl_en_mask rather than ssc_ctrl_reg? > + u32 val = pll_readl(pll->params->ssc_ctrl_reg, pll); > + > + val |= pll->params->ssc_ctrl_en_mask; > + pll_writel(val, pll->params->ssc_ctrl_reg, pll); > + } > +} > + > +static void pll_clk_stop_ss(struct tegra_clk_pll *pll) > +{ > + if (pll->params->defaults_set && pll->params->ssc_ctrl_en_mask) { > + u32 val = pll_readl(pll->params->ssc_ctrl_reg, pll); > + > + val &= ~pll->params->ssc_ctrl_en_mask; > + pll_writel(val, pll->params->ssc_ctrl_reg, pll); > + } > +} > + -- Benson Leung Software Engineer, Chrom* OS bleung@...omium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists