linux-kernel - Re: [Y2038] [PATCH] aoe: Use 64-bit timestamp in frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 May 2015 20:47:01 -0400
From:	Ed Cashin <ed.cashin@....org>
To:	Arnd Bergmann <arnd@...db.de>
CC:	y2038@...ts.linaro.org,
	Tina Ruchandani <ruchandani.tina@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [Y2038] [PATCH] aoe: Use 64-bit timestamp in frame

On 05/13/2015 04:04 AM, Arnd Bergmann wrote:
...
> Shall we do the ktime_get_us() approach then? It still requires a 
> 32-bit division like do_gettimeofday(), so it will not be as efficient 
> as the shifted nanoseconds.

It's no worse, though, right?  So I think it's a good transition. Further
optimization could be attempted in an experimental branch at some
point for easy testing.

> As for the aoe_deadsecs computation, converting the aoe_deadsec module 
> parameter into scaled nanoseconds can be done at module load time, and 
> that way you also save the integer division you currently do for each 
> frame in rexmit_timer() to turn the microseconds into seconds. Arnd 

That's true, but the "secs" in the identifier stands for "seconds". It would
be misleading to have something called seconds be scaled nanoseconds.
And we could just use another variable if it weren't for the fact that this
module parameter is exposed through sysfs and can be changed through
that mechanism at any time.

-- 
   Ed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/