linux-kernel - Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 May 2015 21:12:21 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jonathan Richardson <jonathar@...adcom.com>
Cc:	Scott Branden <sbranden@...adcom.com>,
	Dmitry Torokhov <dtor@...gle.com>,
	Anatol Pomazau <anatol@...gle.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

On Thu, May 14, 2015 at 12:55:32PM -0700, Jonathan Richardson wrote:
> On 15-05-14 12:08 PM, Mark Brown wrote:

> > All it takes is one hardware engineer who sees a SPI controller and a
> > GPIO they can use for chip select; I wouldn't be so sure that nobody
> > ever fixed this up locally (or happened to use a device that only needed
> > single duplex).

> Hi Mark. Would it help if we just set the flags to half duplex using
> SPI_MASTER_HALF_DUPLEX when we register the master?

That would deal with the data corruption issues, yes.  Though it seems
like there are some people who want full duplex support here - I don't
know if any of them can point you at suitable hardware to test?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)