linux-kernel - Re: [alsa-devel] [PATCH] ASoC: skip legacy dai naming if dai driver has all the information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 May 2015 13:07:53 -0700
From:	Kenneth Westfield <kwestfie@...eaurora.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.de>,
	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: skip legacy dai naming if dai driver
 has	all the information

On Fri, May 15, 2015 at 02:38:27AM -0700, Srinivas Kandagatla wrote:
> Original issue is that the id field in the dai is not same as the id
> in dai_driver when dai driver count == 1. This is due to the legacy
> dai naming check, which could possibly cause issues if the audio drivers
> written in assumption that dai->id would be always equal to
> dai_driver->id.
> This assumption is true only if the dai driver count is greater than 1,
> and false if dai driver count is 1. On Qcom Lpass driver we hit such
> issue while adding support to apq8016.
> 
> The code path which falls back to legacy naming for cases where num_dai
> == 1 does not check if there is any valid information in the dai_driver.
> This patch fixes that by checking if the dai_driver has valid id and
> name before falling back to legacy dai naming
> Although the drivers can work around this issue by only using
> dai->driver->id, but this patch attempts to fix the actual issue.
> 
> Suggested-by: Lars-Peter Clausen <lars@...afoo.de>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---

Acked-by: Kenneth Westfield <kwestfie@...eaurora.org>

-- 
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/