| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 May 2015 02:56:29 -0400 (EDT)
From: Mikulas Patocka <mpatocka@...hat.com>
To: Michal Januszewski <spock@...too.org>
cc: linux-fbdev@...r.kernel.org,
Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
Tomi Valkeinen <tomi.valkeinen@...com>,
linux-kernel@...r.kernel.org
Subject: [PATCH] uvesafb: make scaling configurable on Nvidia cards
uvesafb: make scaling configurable on Nvidia cards
Nvidia cards have a BIOS function 0x4f14 that allows to set flat panel
scaling. This patch adds a module parameter "scaling" that uses this
function to set the scaling. By default, the parameter is -1, so that the
driver doesn't attempt to call the scaling function.
This patch is useful when using the binary Nvidia graphics driver - in
that case, the console may be only in text mode or VESA mode. By default,
the video card does scaling that degrades font quality and changes aspect
ratio. This patch makes it possible to turn off the scaling and improve
font quality on the console.
The allowed values depend on VESA BIOS. On my card, the following values
are allowed:
-1 - do not change the scaling
0 - scale to full screen
1, 2 - don't scale
3 - scale and preserve aspect ratio
4 - scale with black border around
Example use:
echo 1 >/sys/module/uvesafb/parameters/scaling; fbset 1280x1024-60 -depth 32 -a
- this sets unscaled 1280x1024 video mode that has much sharper font than
the scaled modes.
I'm suggesting to backport this to stable kernels. The patch doesn't
really fix a bug, but it enhances user experience significantly - the
unscaled console font looks much better than the scaled font. By default,
the patch does nothing, so it can't break any existing system.
Signed-off-by: Mikulas Patocka <mpatocka@...hat.com>
Cc: stable@...r.kernel.org
Index: linux-2.6/drivers/video/fbdev/uvesafb.c
===================================================================
--- linux-2.6.orig/drivers/video/fbdev/uvesafb.c
+++ linux-2.6/drivers/video/fbdev/uvesafb.c
@@ -52,6 +52,7 @@ static u16 maxclk; /* maximum pixel clo
static u16 maxvf; /* maximum vertical frequency */
static u16 maxhf; /* maximum horizontal frequency */
static u16 vbemode; /* force use of a specific VBE mode */
+static short scaling = -1;
static char *mode_option;
static u8 dac_width = 6;
@@ -1245,7 +1246,22 @@ static int uvesafb_set_par(struct fb_inf
task = uvesafb_prep();
if (!task)
return -ENOMEM;
+
+ if (scaling > 0) {
+ /*
+ * We must first reset scaling state with 0. This is workaround
+ * for some supposed BIOS bug - without this, scaling mode 4
+ * could not be set.
+ */
+ uvesafb_reset(task);
+ task->t.regs.eax = 0x4f14;
+ task->t.regs.ebx = 0x0102;
+ task->t.regs.ecx = 0;
+ uvesafb_exec(task);
+ }
+
setmode:
+ uvesafb_reset(task);
task->t.regs.eax = 0x4f02;
task->t.regs.ebx = mode->mode_id | 0x4000; /* use LFB */
@@ -1296,7 +1312,6 @@ setmode:
printk(KERN_WARNING "uvesafb: mode switch failed "
"(eax=0x%x, err=%d). Trying again with "
"default timings.\n", task->t.regs.eax, err);
- uvesafb_reset(task);
kfree(crtc);
crtc = NULL;
info->var.pixclock = 0;
@@ -1330,6 +1345,14 @@ setmode:
FB_VISUAL_PSEUDOCOLOR : FB_VISUAL_TRUECOLOR;
info->fix.line_length = mode->bytes_per_scan_line;
+ if (scaling >= 0) {
+ uvesafb_reset(task);
+ task->t.regs.eax = 0x4f14;
+ task->t.regs.ebx = 0x0102;
+ task->t.regs.ecx = scaling;
+ uvesafb_exec(task);
+ }
+
out:
kfree(crtc);
uvesafb_free(task);
@@ -2019,6 +2042,9 @@ MODULE_PARM_DESC(vbemode,
"VBE mode number to set, overrides the 'mode' option");
module_param_string(v86d, v86d_path, PATH_MAX, 0660);
MODULE_PARM_DESC(v86d, "Path to the v86d userspace helper.");
+module_param(scaling, short, 0660);
+MODULE_PARM_DESC(scaling,
+ "Scaling option for nvidia (0 - scaled, 1 - unscaled centered, 2 - unscaled in left corner");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Michal Januszewski <spock@...too.org>");
Index: linux-2.6/Documentation/fb/uvesafb.txt
===================================================================
--- linux-2.6.orig/Documentation/fb/uvesafb.txt
+++ linux-2.6/Documentation/fb/uvesafb.txt
@@ -128,6 +128,14 @@ v86d:path
need to use it and have uvesafb built into the kernel, use
uvesafb.v86d="path".
+scaling:n
+ Set scaling on Nvidia cards. Possible values depend on card's BIOS.
+ -1 - do not change the scaling
+ 0 - scale to full screen
+ 1, 2 - don't scale
+ 3 - scale and preserve aspect ratio
+ 4 - scale with black border around
+
Additionally, the following parameters may be provided. They all override the
EDID-provided values and BIOS defaults. Refer to your monitor's specs to get
the correct values for maxhf, maxvf and maxclk for your hardware.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists