linux-kernel - Re: [PATCH 2/2] twl4030_charger: find associated phy by more reliable means.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 17 May 2015 11:56:12 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Felipe Balbi <balbi@...com>
Cc:	NeilBrown <neil@...wn.name>, Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-pm@...r.kernel.org, NeilBrown <neilb@...e.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pavel Machek <pavel@....cz>
Subject: Re: [PATCH 2/2] twl4030_charger: find associated phy by more
 reliable means.

Hi,

On Fri, May 08, 2015 at 11:12:05AM -0500, Felipe Balbi wrote:
> On Mon, Mar 23, 2015 at 09:52:48AM +1100, NeilBrown wrote:
> > From: NeilBrown <neilb@...e.de>
> > 
> > twl4030_charger currently finds the associated phy
> > using usb_get_phy() which will return the first USB2 phy.
> > If your platform has multiple such phys (as mine does),
> > this is not reliable (and reliably fails on the GTA04).
> > 
> > Change to use devm_usb_get_phy_by_node(), having found the
> > node by looking for an appropriately named sibling in
> > device-tree.
> > 
> > This makes usb-charging dependent on correct device-tree
> > configuration.
> > 
> > Acked-by: Pavel Machek <pavel@....cz>
> > Signed-off-by: NeilBrown <neilb@...e.de>
> > ---
> 
> Sebastian, can I get your Acked-by here ?

Acked-By: Sebastian Reichel <sre@...nel.org>

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)