linux-kernel - Re: [PATCH 1/1] power: validate wakeup source before activating it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 May 2015 02:34 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Jin Qian <jinqian@...roid.com>
Cc:	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] power: validate wakeup source before activating it.

On Friday, May 15, 2015 06:28:17 PM Jin Qian wrote:
> Hi Rafael,
> 
> The latest version is in [PATCHv3 1/3] power: validate wakeup source
> before activating it. I changed WARN_ONCE back to WARN since if
> multiple drivers activating uninitialized wakeup_sources, only the
> first driver will by flagged.

Which is OK.

If you're a user, you can't fix the problem by yourself and spamming the
logs with continued warnings doesn't help here.

If you're a developer, you'll fix the first driver and then see the
warning from the second one.

> We lost alert for other drivers. The warning should really happen during
> driver development. Hope this is ok.

First, I've applied your patch already.  Second, I really think that
WARN_ON_ONCE() is better here.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/