linux-kernel - Re: [PATCH v1 1/1] ARM: EXYNOS: fix DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 May 2015 10:52:14 +0900
From:	Chanho Park <parkch98@...il.com>
To:	Tarek Dakhran <t.dakhran@...il.com>
Cc:	kgene@...nel.org, Russell King <linux@....linux.org.uk>,
	k.kozlowski@...sung.com, t.figa@...sung.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	jy0922.shim@...sung.com
Subject: Re: [PATCH v1 1/1] ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.

Hi Tarek,

On Sun, May 17, 2015 at 3:42 PM, Tarek Dakhran <t.dakhran@...il.com> wrote:
> Cortex-A7 has EXYNOS5_PA_UART base address for UART.
> If system boots from Cortex-A7 CPU addruart loads wrong
> address. This patch fixex this.
>
> Signed-off-by: Tarek Dakhran <t.dakhran@...il.com>
> ---
>  arch/arm/include/debug/exynos.S | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/include/debug/exynos.S b/arch/arm/include/debug/exynos.S
> index b17fdb7..a61b3ea 100644
> --- a/arch/arm/include/debug/exynos.S
> +++ b/arch/arm/include/debug/exynos.S
> @@ -24,6 +24,7 @@
>                 mrc     p15, 0, \tmp, c0, c0, 0
>                 and     \tmp, \tmp, #0xf0
>                 teq     \tmp, #0xf0             @@ A15
> +               teqne   \tmp, #0x70             @@ A7
>                 ldreq   \rp, =EXYNOS5_PA_UART
>                 movne   \rp, #EXYNOS4_PA_UART   @@ EXYNOS4
>                 ldr     \rv, =S3C_VA_UART
> --
> 1.9.1
>

Please see previous Joonyoung's patch. Your patch could break
exynos3250 because it has not only two cortex-a7 cpus but also uses
EXYOS4_PA_UART.

http://www.spinics.net/lists/linux-samsung-soc/msg37318.html

-- 
Best Regards,
Chanho Park
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/