linux-kernel - [EDT][PATCH] kernel/exit.c : Fix missing read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 May 2015 05:00:03 +0000 (GMT)
From:	Maninder Singh <maninder1.s@...sung.com>
To:	akpm@...ux-foundation.org, oleg@...hat.com, mhocko@...e.cz,
	peterz@...radead.org, mingo@...nel.org, riel@...hat.com,
	ionut.m.alexa@...il.com, peter@...leysoftware.com,
	linux-kernel@...r.kernel.org,
	"v.narang@...sung.com" <v.narang@...sung.com>,
	AKHILESH KUMAR <akhilesh.k@...sung.com>
Subject: [EDT][PATCH] kernel/exit.c : Fix missing read_unlock

 EP-F6AA0618C49C4AEDA73BFF1B39950BAB
Hi,

From: Maninder Singh <maninder1.s@...sung.com>

Subject: [PATCH 1/1] kernel/exit.c : Fix missing task_unlock

This patch adds missing read_unlock if do_wait_thread or ptrace_do_wait 
returns non zero.

Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
Signed-off-by: Vaneet Narang <v.narang@...sung.com>
Reviewd-by: Akhilesh Kumar <akhilesh.k@...sung.com>
---
 kernel/exit.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/kernel/exit.c b/kernel/exit.c
index 22fcc05..31a061f 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1486,12 +1486,16 @@ repeat:
 	tsk = current;
 	do {
 		retval = do_wait_thread(wo, tsk);
-		if (retval)
+		if (retval) {
+			read_unlock(&tasklist_lock);
 			goto end;
+		}
 
 		retval = ptrace_do_wait(wo, tsk);
-		if (retval)
+		if (retval) {
+			read_unlock(&tasklist_lock);
 			goto end;
+		}
 
 		if (wo->wo_flags & __WNOTHREAD)
 			break;
-- 
1.7.1

Thanks 
Maninder Singh