linux-kernel - Re: [PATCH] regulator: core: fix constraints debug output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 May 2015 08:42:43 +0200 (CEST)
From:	Stefan Wahren <stefan.wahren@...e.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH] regulator: core: fix constraints debug output

Hi Joe,

> Joe Perches <joe@...ches.com> hat am 20. Mai 2015 um 22:35 geschrieben:
>
>
> On Wed, 2015-05-20 at 20:17 +0000, Stefan Wahren wrote:
> > In the case uV_offset is greater than 0 the debug output before
> > is accidentally overwritten. So take care of the output count.
>
> If you are going to take care, please change all of these
> sprintf calls to snprintf.

thanks for pointing out. I will create a second version.

But using scnprintf should be better here.

>
> The buf array may not be big enough [80] to hold the longest
> possible output string.
>

Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/