linux-kernel - Re: [EDT] [PATCH] devpts/inode.c : Fix Possible dentry NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 May 2015 12:12:38 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	akpm@...ux-foundation.org, dhowells@...hat.com, fabf@...net.be,
	linux-kernel@...r.kernel.org,
	"v.narang@...sung.com" <v.narang@...sung.com>
Subject: Re: [EDT] [PATCH] devpts/inode.c : Fix Possible dentry NULL
 dereference

On Thu, May 21, 2015 at 10:28:52AM +0000, Maninder Singh wrote:

> Subject: [PATCH 1/1] devpts/inode.c : Fix Possible dentry NULL dereference
> 
> Issue reported by static tool Analyzer (Prevent).
> d_find_alias can return NULL to deentry, Thus we need NULL check 
> before calling d_delete(dentry)

No, we do not.  That inode must have come from devpts_pty_new() and it
wouldn't have made it out of there without having a dentry attached to
it (and pinned).

NAK.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/